fix: store multiple double spend attempts #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
commented
Jun 19, 2024
| let mut txs = BTreeSet::new(); | ||
| for spend in spends.into_iter() { | ||
| txs.insert(spend.spend.spent_tx.clone()); | ||
| spend_processing |
There was a problem hiding this comment.
Earlier only the first spend was sent for spend_processing, but here we do it for all the spends, is this alright?
RolandSherwin
force-pushed
the
store_more_double_spends
branch
from
82f23e3 to
86edf7a
Compare
b-zee
approved these changes
Jun 20, 2024
| spend_processing | ||
| .send(first_spend.clone()) | ||
| .await | ||
| .map_err(|e| WalletError::SpendProcessing(e.to_string()))?; | ||
|
|
||
| // use iteration instead of recursion to avoid stack overflow |
There was a problem hiding this comment.
Comment not relevant anymore?
There was a problem hiding this comment.
I think it is for the one inside the for loop? I'm not sure.
RolandSherwin
force-pushed
the
store_more_double_spends
branch
from
86edf7a to
c595c80
Compare
RolandSherwin
changed the title
RolandSherwin
force-pushed
the
store_more_double_spends
branch
from
c595c80 to
d37ce9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.